Skip to content
This repository has been archived by the owner on Apr 14, 2019. It is now read-only.

added rail fence cipher #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added rail fence cipher #15

wants to merge 1 commit into from

Conversation

debck
Copy link

@debck debck commented Dec 19, 2017

screenshot_2017-12-19-10-24-50-853_com android chrome

@debck
Copy link
Author

debck commented Dec 19, 2017

@palash25 python3 is not running in my pc.
so i ran it online .
plz check it

Copy link
Owner

@palash25 palash25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the main function below and encrypt function at the top. Do it in the same commit by using git add . and then git commit -a --amend after you are done with your changes. Also where is the decrypt function.

@palash25
Copy link
Owner

Oh and follow this guide to setup your development environment http://docs.python-guide.org/en/latest/

Copy link
Contributor

@sibasish14 sibasish14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debck

  1. It would be better if you print your output in the same manner just like your input.
    Input - you cannot see me
    Output - ycn smoaoe eun te
    If you do not maintain spaces you might be scratching your head while decrypting.

  2. Add a decrypt function.

  3. I think both python2 & python3 come built-in with most linux distros. Don't you use one?

@pep8speaks
Copy link

pep8speaks commented Dec 30, 2017

Hello @debck! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on December 30, 2017 at 05:39 Hours UTC

@palash25
Copy link
Owner

@sibasish14 can you test and review it and let me know when it will be ready for merging?

@@ -0,0 +1,58 @@
def encrypt(clearText, key):
Copy link
Contributor

@sibasish14 sibasish14 Dec 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debck add the name of the cipher in a comment line at the top.

Copy link
Contributor

@sibasish14 sibasish14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debck your code is giving the following errors :
screenshot from 2017-12-30 11-39-41

Fix them. Also your output doesn't seem convincing. It's not in the same format as that of your input.
P.S. - Test your codes before pushing. Attach a screenshot of your output next time you push a commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants