-
Notifications
You must be signed in to change notification settings - Fork 5
added rail fence cipher #15
base: master
Are you sure you want to change the base?
Conversation
debck
commented
Dec 19, 2017
@palash25 python3 is not running in my pc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the main function below and encrypt function at the top. Do it in the same commit by using git add .
and then git commit -a --amend
after you are done with your changes. Also where is the decrypt
function.
Oh and follow this guide to setup your development environment http://docs.python-guide.org/en/latest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
It would be better if you print your output in the same manner just like your input.
Input -you cannot see me
Output -ycn smoaoe eun te
If you do not maintain spaces you might be scratching your head while decrypting. -
Add a decrypt function.
-
I think both python2 & python3 come built-in with most linux distros. Don't you use one?
Hello @debck! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 30, 2017 at 05:39 Hours UTC |
@sibasish14 can you test and review it and let me know when it will be ready for merging? |
@@ -0,0 +1,58 @@ | |||
def encrypt(clearText, key): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debck add the name of the cipher in a comment line at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debck your code is giving the following errors :
Fix them. Also your output doesn't seem convincing. It's not in the same format as that of your input.
P.S. - Test your codes before pushing. Attach a screenshot of your output next time you push a commit.