You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 19, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message output text is different for different language settings and different distributions of git. So maybe we shouldn't use git's error output in logic.
This code works as expected in every language configuration and git distribution
Possible downsides?
The behavior before and after the PR is consistent for existing versions of git. But this seems to depend on git's internal implementation, don't know if there is a better way.
Thanks for your interest in palantir/gradle-revapi, @izchen! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.
The error message output text is different for different language settings and different distributions of git. So maybe we shouldn't use git's error output in logic.
This code works as expected in every language configuration and git distribution
Possible downsides?
The behavior before and after the PR is consistent for existing versions of git. But this seems to depend on git's internal implementation, don't know if there is a better way.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The error message output text is different for different language settings and different distributions of git. So maybe we shouldn't use git's error output in logic.
Related issues: #550
https://github.com/git/git/tree/master/po#contributing-to-an-existing-translation
After this PR
This code works as expected in every language configuration and git distribution
Possible downsides?
The behavior before and after the PR is consistent for existing versions of git. But this seems to depend on git's internal implementation, don't know if there is a better way.