Skip to content

Commit

Permalink
Merge pull request #28 from michael-yx-wu/chore/remove-force-flag-fro…
Browse files Browse the repository at this point in the history
…m-dockerTag

Remove force flag from docker tag
  • Loading branch information
markelliot committed Apr 8, 2016
2 parents 5a4cf16 + ba23830 commit 74d6463
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ machine:
java:
version: openjdk7
pre:
- curl -sSL https://s3.amazonaws.com/circle-downloads/install-circleci-docker.sh | bash -s -- 1.10.3
- curl -sSL https://s3.amazonaws.com/circle-downloads/install-circleci-docker.sh | bash -s -- 1.10.0
- sudo wget -O /usr/local/bin/docker-compose 'https://github.com/docker/compose/releases/download/1.6.2/docker-compose-Linux-x86_64'
- sudo chmod 0755 /usr/local/bin/docker-compose
services:
Expand All @@ -24,4 +24,3 @@ deployment:
commands:
- ./gradlew -i bintrayUpload
- ./gradlew -i -Dgradle.publish.key=$GRADLE_KEY -Dgradle.publish.secret=$GRADLE_SECRET publishPlugins

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class PalantirDockerPlugin implements Plugin<Project> {
group = 'Docker'
description = "Tags Docker image with tag '${tagName}'"
workingDir dockerDir
commandLine 'docker', 'tag', '--force=true', ext.name, computeName(ext.name, tagName)
commandLine 'docker', 'tag', ext.name, computeName(ext.name, tagName)
dependsOn exec
})
tag.dependsOn subTask
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class PalantirDockerPluginTests extends AbstractPluginTest {
buildResult.task(':dockerPrepare').outcome == TaskOutcome.SUCCESS
buildResult.task(':docker').outcome == TaskOutcome.SUCCESS
exec("docker inspect --format '{{.Author}}' ${id}") == "'${id}'\n"
execCond("docker rmi -f ${id}")
execCond("docker rmi -f ${id}") || true
}

def 'Publishes "docker" dependencies via "docker" component'() {
Expand Down

0 comments on commit 74d6463

Please sign in to comment.