Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker output directory as a concept #428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Dec 16, 2023

Before this PR

After this PR

==COMMIT_MSG==
Adds an "output-dir" concept for DockerConfig that is analogous to what exists for BuildConfig and DistConfig. Also updates the existing OCI output to use this concept.
==COMMIT_MSG==

This makes the concept of Docker build/dist outputs more first-class. The removes some of the hackiness of the previous OCI implementation and also allows for supporting Docker metadata artifacts.

Possible downsides?


This change is Reviewable

Add an "output-dir" concept for DockerConfig that is analgous
to what exists for BuildConfig and DistConfig. Also updates the
existing OCI output to use this concept.

This makes the concept of Docker build/dist outputs more first-class.
The removes some of the hackiness of the previous OCI implementation
and also allows for supporting Docker metadata artifacts.
@changelog-app
Copy link

changelog-app bot commented Dec 16, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Adds an "output-dir" concept for DockerConfig that is analogous to what exists for BuildConfig and DistConfig. Also updates the existing OCI output to use this concept.

Check the box to generate changelog(s)

  • Generate changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants