Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement koji_build trigger for koji_build job #2457

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Implement koji_build trigger for koji_build job #2457

merged 4 commits into from
Jul 16, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Jul 8, 2024 •
edited
Loading

Fixes #2378.

Merge after packit/packit#2349.
Merge after packit/packit#2350.

@nforro nforro changed the title Sidetags Implement koji_build trigger for koji_build job Jul 8, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro marked this pull request as ready for review July 10, 2024 16:46
@nforro

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ccd6080a2721439d970125bf1e6d8e2f

✔️ pre-commit SUCCESS in 2m 18s
✔️ packit-service-tests SUCCESS in 2m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4901d1db48b246e08d05583146208210

✔️ pre-commit SUCCESS in 2m 17s
✔️ packit-service-tests SUCCESS in 2m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/603d4b5ba50c4f1abd0510d311deaaf8

✔️ pre-commit SUCCESS in 2m 14s
✔️ packit-service-tests SUCCESS in 2m 35s

lbarcziova
lbarcziova reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work!

packit_service/worker/handlers/koji.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/78c540717967497a8dad8efd0d62b9f1

✔️ pre-commit SUCCESS in 2m 42s
✔️ packit-service-tests SUCCESS in 2m 53s

lbarcziova
lbarcziova approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Jul 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fae25b3bc206484e83dfc8eddd484124

✔️ pre-commit SUCCESS in 2m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4c5ea60 into packit:main Jul 16, 2024
4 checks passed
@nforro nforro deleted the sidetags branch July 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement koji_build trigger for koji_build job
2 participants
@nforro @lbarcziova