Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidetag support for koji_build #2409

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Apr 27, 2024

Tested locally, seems to work like a charm.

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes #2377.

Merge after packit/packit#2299.

RELEASE NOTES BEGIN

koji_build job has a new sidetag_group option that allows to perform a downstream Koji build in a sidetag. A new sidetag will be created for each configured dist_git_branch if it doesn't already exist.

RELEASE NOTES END

Copy link
Contributor

@nforro
Copy link
Member Author

nforro commented Apr 29, 2024

recheck

Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nforro
Copy link
Member Author

nforro commented Apr 29, 2024

[ ] Update or write new documentation in packit/packit.dev.

I don't think it makes much sense to document this now as practical use is quite limited until the follow-up issues are implemented.

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Apr 29, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/491efb9741bb4fd3bb1b0815981d0536

✔️ pre-commit SUCCESS in 11m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e988390 into packit:main Apr 29, 2024
4 checks passed
@nforro nforro deleted the sidetags branch April 29, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sidetag support to koji_build job
2 participants