Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add pagination to project endpoints #2349

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Feb 14, 2024

No pagination was present with some of the endpoints which resulted in the duplicate data being presented in the views on dashboard.

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes packit/dashboard#376


RELEASE NOTES BEGIN
We have fixed an issue that caused loading the same data multiple times on the dashboard within the project views.
RELEASE NOTES END

@mfocko mfocko self-assigned this Feb 14, 2024
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

No pagination was present with some of the endpoints which resulted in
the duplicate data being presented in the views on dashboard.

Fixes packit/dashboard#376

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko force-pushed the fix/dashboard-repos-pagination branch from d69e7b2 to b297d48 Compare February 15, 2024 13:28
@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Feb 15, 2024
Copy link
Contributor

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/69cdcf4e29b54095bbe1ec09637e6030

✔️ pre-commit SUCCESS in 1m 59s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9644107 into packit:main Feb 15, 2024
3 checks passed
Copy link

sentry-io bot commented Feb 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly api.projects_project_branches View Issue

Did you find this useful? React with a 👍 or 👎

@mfocko mfocko deleted the fix/dashboard-repos-pagination branch February 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Load More" button on the Projects page keeps appending the repo list when pressed.
2 participants