Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process message task improvements #2326

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Process message task improvements #2326

merged 2 commits into from
Feb 2, 2024

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Jan 31, 2024 •
edited
Loading

Fixes #2323
Related to #2290

RELEASE NOTES BEGIN
We have added additional retries and improvements for task processing.
RELEASE NOTES END

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/77d714d3372741be91f70a3584e0e5d7

✔️ pre-commit SUCCESS in 1m 59s
✔️ packit-service-tests SUCCESS in 2m 20s

nforro
nforro approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nitpick, I'd maybe factor out the HandlerTaskWithRetry rename to a separate commit for more clarity.

@lbarcziova
Set lower hard time limit for process message
a4df126 
This task should be exetuced much faster, it doesn't execute any
user defined actions etc., therefore set the time limit lower
than the global one (900s).
Related to packit#2290
@lbarcziova
Make process_message task use TaskWithRetry as base
7616975 
Raneme HandlerTaskWithRetry to TaskWithRetry and make
process_message task use it as base as well
so that the process_message tasks are retried as well.
Fixes packit#2323
@lbarcziova
Copy link
Member Author

Just a little nitpick, I'd maybe factor out the HandlerTaskWithRetry rename to a separate commit for more clarity.

I have adjusted the commit message to mention the renaming, but to me it makes sense to have it in one commit as it explains why was the renaming done.

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Feb 2, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2ac3c2b13334429c9023461c1c47c773

✔️ pre-commit SUCCESS in 5m 28s
✔️ packit-service-tests SUCCESS in 2m 12s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fdaf242d13f143b4a211a822b7cedd6a

✔️ pre-commit SUCCESS in 1m 59s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1930010 into packit:main Feb 2, 2024
3 checks passed
@lbarcziova lbarcziova deleted the time-limit-process branch February 2, 2024 11:16
This was referenced Feb 2, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

@majamassarini majamassarini majamassarini approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement retries for process_message task
3 participants
@lbarcziova @majamassarini @nforro