Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidetag support to koji_build job #2377

Closed
3 tasks
nforro opened this issue Mar 21, 2024 · 0 comments · Fixed by #2409
Closed
3 tasks

Add sidetag support to koji_build job #2377

nforro opened this issue Mar 21, 2024 · 0 comments · Fixed by #2409
Assignees
@nforro
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.

Comments

@nforro
Copy link
Member

nforro commented Mar 21, 2024 •
edited
Loading

Here is Fedora documentation on using sidetags: https://docs.fedoraproject.org/en-US/rawhide-gating/multi-builds/

TODO:

  • create a table that will map a sidetag identifier and a dist-git branch name to an actual sidetag name in Koji
    (sidetag name looks like f39-build-side-12345 where the first part is a base tag determined from dist-git branch)
  • add a new config option to specify this sidetag identifier (it can be probably called just sidetag or side_tag)
  • implement building in a sidetag:
    • check if a mapping for the defined sidetag identifier and the current dist-git branch exists
    • if it does, check that the actual sidetag still exists in Koji (koji taginfo $SIDETAG), if not, remove the mapping
    • if it doesn't, request a sidetag (fedpkg request-side-tag) and add a new mapping
    • use the sidetag as build target (fedpkg build --target=$SIDETAG)
@nforro nforro transferred this issue from packit/packit Mar 21, 2024
@nforro nforro mentioned this issue Mar 21, 2024
Closed
@nforro nforro added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Mar 21, 2024
@nforro nforro moved this from new to priority-backlog in Packit Kanban Board Mar 21, 2024
@mfocko mfocko moved this from priority-backlog to refined in Packit Kanban Board Apr 11, 2024
@nforro nforro self-assigned this Apr 16, 2024
@nforro nforro moved this from refined to in-progress in Packit Kanban Board Apr 16, 2024
@nforro nforro mentioned this issue Apr 24, 2024
Merged
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue Apr 25, 2024
@softwarefactory-project-zuul
Add sidetag related methods to KojiHelper (#2295)
d3cd78c 
Add sidetag related methods to KojiHelper

Related to packit/packit-service#2377.

Reviewed-by: Laura Barcziová
This was referenced Apr 27, 2024
Merged
Merged
@nforro nforro moved this from in-progress to in-review in Packit Kanban Board Apr 27, 2024
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue Apr 29, 2024
@softwarefactory-project-zuul
Add sidetag_group config option for koji_build and bodhi_update (#2299)
00b6e60 
Add sidetag_group config option for koji_build and bodhi_update

Related to packit/packit-service#2377.

Reviewed-by: Laura Barcziová
softwarefactory-project-zuul bot added a commit that referenced this issue Apr 29, 2024
@softwarefactory-project-zuul
Add sidetag support for koji_build (#2409)
e988390 
Add sidetag support for koji_build

Tested locally, seems to work like a charm.
TODO:

 Write new tests or update the old ones to cover new functionality.
 Update doc-strings where appropriate.
 Update or write new documentation in packit/packit.dev.

Fixes #2377.
Merge after packit/packit#2299.
RELEASE NOTES BEGIN
koji_build job has a new sidetag_group option that allows to perform a downstream Koji build in a sidetag. A new sidetag will be created for each configured dist_git_branch if it doesn't already exist.
RELEASE NOTES END

Reviewed-by: Laura Barcziová
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nforro nforro

Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sidetag support for koji_build nforro/packit-service
1 participant
@nforro