Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement retries for process_message task #2323

Closed
lbarcziova opened this issue Jan 26, 2024 · 0 comments · Fixed by #2326
Closed

Implement retries for process_message task #2323

lbarcziova opened this issue Jan 26, 2024 · 0 comments · Fixed by #2326
Assignees
@lbarcziova
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

For the handler tasks, we have the retries implemented by inheriting from this class.

We should do this also for process_message task, as exceptions, such as network flakes, now appear as no reaction to user, resulting in poor UX.
@nforro nforro added kind/bug Something isn't working. complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. area/general Related to whole service, not a specific part/integration. gain/high This brings a lot of value to (not strictly a lot of) users. labels Jan 29, 2024
@nforro nforro moved this from new to priority-backlog in Packit Kanban Board Jan 29, 2024
@nforro nforro mentioned this issue Jan 30, 2024
Closed
@lbarcziova lbarcziova moved this from priority-backlog to in-progress in Packit Kanban Board Jan 31, 2024
@lbarcziova lbarcziova self-assigned this Jan 31, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jan 31, 2024
@lbarcziova
Make process_message task use TaskWithRetry as base
2269645 
So that the process_message tasks are retried as well.
Fixes packit#2323
@lbarcziova lbarcziova mentioned this issue Jan 31, 2024
Merged
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Jan 31, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Feb 2, 2024
@lbarcziova
Make process_message task use TaskWithRetry as base
7616975 
Raneme HandlerTaskWithRetry to TaskWithRetry and make
process_message task use it as base as well
so that the process_message tasks are retried as well.
Fixes packit#2323
softwarefactory-project-zuul bot added a commit that referenced this issue Feb 2, 2024
@softwarefactory-project-zuul
Process message task improvements (#2326)
1930010 
Process message task improvements

Fixes #2323
Related to #2290

RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Maja Massarini
Reviewed-by: Nikola Forró
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Process message task improvements lbarcziova/packit-service
2 participants
@nforro @lbarcziova