Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Load More" button on the Projects page keeps appending the repo list when pressed. #376

Closed
2 tasks done
ckelleyRH opened this issue Feb 13, 2024 · 1 comment · Fixed by packit/packit-service#2349
Closed
2 tasks done

"Load More" button on the Projects page keeps appending the repo list when pressed. #376

ckelleyRH opened this issue Feb 13, 2024 · 1 comment · Fixed by packit/packit-service#2349
Assignees
@mfocko
Labels
area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.

Comments

@ckelleyRH
Copy link

What happened? What is the problem?

The "Load More" button at /projects/<forge>/<namespace>/ keeps appending the repo list when pressed.

What did you expect to happen?

Nothing, all repos in the namespace are already visible in the list.

Example URL(s)

https://dashboard.packit.dev/projects/github.com/FasterXML

Steps to reproduce

1. Goto https://dashboard.packit.dev/projects/github.com/FasterXML 
2. Click "Load More" a few times

Reloading the page clears the duplicates out and returns the page to normal.

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@lachmanfrantisek lachmanfrantisek added kind/bug Something isn't working. area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. labels Feb 13, 2024
@mfocko
Copy link
Member

mfocko commented Feb 14, 2024

Hi 👋 thanks for reporting this issue, I've glanced over it and it looks like we don't have the pagination very consistently used across our API endpoints which basically causes “reloading” everything instead of adding more repos. Will fix it right away, since it will take less time than planning ;)

mfocko added a commit to mfocko/packit-service that referenced this issue Feb 14, 2024
@mfocko
fix(api): add pagination to project endpoints
d69e7b2 
No pagination was present with some of the endpoints which resulted in
the duplicate data being presented in the views on dashboard.

Fixes packit/dashboard#376

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko mentioned this issue Feb 14, 2024
Merged
3 tasks
@mfocko mfocko moved this from new to in-review in Packit Kanban Board Feb 14, 2024
mfocko added a commit to mfocko/packit-service that referenced this issue Feb 15, 2024
@mfocko
fix(api): add pagination to project endpoints
b297d48 
No pagination was present with some of the endpoints which resulted in
the duplicate data being presented in the views on dashboard.

Fixes packit/dashboard#376

Signed-off-by: Matej Focko <[email protected]>
softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this issue Feb 15, 2024
@softwarefactory-project-zuul
fix(api): add pagination to project endpoints (#2349)
9644107 
fix(api): add pagination to project endpoints

No pagination was present with some of the endpoints which resulted in the duplicate data being presented in the views on dashboard.
TODO:

 Write new tests or update the old ones to cover new functionality.
 Update doc-strings where appropriate.
 Update or write new documentation in packit/packit.dev.



Fixes packit/dashboard#376

RELEASE NOTES BEGIN
We have fixed an issue that caused loading the same data multiple times on the dashboard within the project views.
RELEASE NOTES END

Reviewed-by: Laura Barcziová
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfocko mfocko

Labels
area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): add pagination to project endpoints mfocko/packit-service
3 participants
@mfocko @lachmanfrantisek @ckelleyRH