fix issue with ?null= - jsdom is more forgiving than chrome on `new…

… URLSearchParams(null)`
packaged-ui · Aug 23, 2021 · 4a463c4 · 4a463c4
1 parent c027eb8
commit 4a463c4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@packaged-ui/request",
   "main": "src/request.js",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "type": "module",
   "private": false,
   "repository": "[email protected]:packaged-ui/request.git",

diff --git a/src/request.js b/src/request.js
@@ -189,7 +189,7 @@ export default class Request
                                  .join('&');
           }
         }
-        else
+        else if(this.data !== undefined && this.data !== null)
         {
           if(_method === Request.GET)
           {

diff --git a/test/_setup.js b/test/_setup.js
@@ -2,9 +2,9 @@
 import {JSDOM} from 'jsdom';
 
 export const port = 8877;
-export const server = 'http://127.0.0.1:' + port;
+export const serverUrl = 'http://127.0.0.1:' + port;
 
-export const jsdom = new JSDOM('<!doctype html><html lang="en"><body></body></html>', {url: server});
+export const jsdom = new JSDOM('<!doctype html><html lang="en"><body></body></html>', {url: serverUrl});
 const {window} = jsdom;
 
 function copyProps(src, target)

diff --git a/test/test.js b/test/test.js
@@ -1,4 +1,4 @@
-import {port as _p, server as _s} from './_setup.js';
+import {port as _p, serverUrl as _s} from './_setup.js';
 import http from 'http';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
-Original file line number
+Diff line change
@@ Expand Up / @@ -189,7 +189,7 @@ export default class Request @@
                                      .join('&');
               }
             }
-            else
+            else if(this.data !== undefined && this.data !== null)
             {
               if(_method === Request.GET)
               {
@@ Expand Down @@