-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters to main control for Rx and Tx host metadata #50
Open
jfingerh
wants to merge
1
commit into
p4lang:main
Choose a base branch
from
jfingerh:add-rx-tx-host-descriptor-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -776,6 +776,16 @@ extern T SelectByDirection<T>( | |
|
||
|
||
|
||
// Struct to contain vendor-specific metadata fields that can be | ||
// accessed while pakcets are being processed in the main control. | ||
// The definition of the fields and their behavior is completely | ||
// vendor-specific, and this part of the pna.p4 header file is | ||
// expected to be customized by each vendor implementing PNA. | ||
|
||
struct vendor_metadata_t { | ||
} | ||
|
||
|
||
|
||
// BEGIN:Programmable_blocks | ||
control PreControlT<PH, PM>( | ||
|
@@ -791,10 +801,13 @@ parser MainParserT<PM, MH, MM>( | |
inout MM main_user_meta, | ||
in pna_main_parser_input_metadata_t istd); | ||
|
||
control MainControlT<PM, MH, MM>( | ||
control MainControlT<PM, MH, MM, MTX, MRX>( | ||
//in PM pre_user_meta, | ||
inout MH main_hdr, | ||
inout MM main_user_meta, | ||
inout vendor_metadata_t vmeta, | ||
inout MTX txmeta, | ||
inout MRX rxmeta, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should control block have two separate vendor meta for each direction ? |
||
in pna_main_input_metadata_t istd, | ||
inout pna_main_output_metadata_t ostd); | ||
|
||
|
@@ -804,10 +817,10 @@ control MainDeparserT<MH, MM>( | |
in MM main_user_meta, | ||
in pna_main_output_metadata_t ostd); | ||
|
||
package PNA_NIC<PH, PM, MH, MM>( | ||
package PNA_NIC<PH, PM, MH, MM, MTX, MRX>( | ||
MainParserT<PM, MH, MM> main_parser, | ||
PreControlT<PH, PM> pre_control, | ||
MainControlT<PM, MH, MM> main_control, | ||
MainControlT<PM, MH, MM, MTX, MRX> main_control, | ||
MainDeparserT<MH, MM> main_deparser); | ||
// END:Programmable_blocks | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is line 808 needed ?