Add Ecdsa adaptor and schnorr signature from temp-everything branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkohen
reviewed
Aug 31, 2020
src/schnorrsig.rs
Outdated
| &self, | ||
| msg: &Message, | ||
| sk: &SecretKey, | ||
| nonce: &SchnorrNonce, |
There was a problem hiding this comment.
Actually I think this is meant to be a private key, k, whereas the type SchnorrNonce represents public keys R = k*G. The name is kind of confusing because both k and R values are sometimes called the nonce...
There was a problem hiding this comment.
Good catch thanks! I indeed got confused because it was called nonce, changed to private key.
Tibo-lg
force-pushed
the
ecdsa-adaptor
branch
2 times, most recently
from
31de6a1 to
8b749bc
Compare
Tibo-lg
force-pushed
the
ecdsa-adaptor
branch
2 times, most recently
from
cc09fb7 to
7200202
Compare
Tibo-lg
force-pushed
the
ecdsa-adaptor
branch
from
7200202 to
e2c31f7
Compare
Tibo-lg
force-pushed
the
ecdsa-adaptor
branch
from
6c31918 to
b9821a0
Compare
Tibo-lg
force-pushed
the
add-bip340-schnorr
branch
8 times, most recently
from
d9a83e3 to
49923a9
Compare
Tibo-lg
force-pushed
the
add-bip340-schnorr
branch
from
49923a9 to
d75259f
Compare
Tibo-lg
force-pushed
the
add-bip340-schnorr
branch
10 times, most recently
from
7e8eb2d to
4f6699c
Compare
Tibo-lg
force-pushed
the
ecdsa-adaptor
branch
2 times, most recently
from
987c5dd to
0911eda
Compare
Tibo-lg
force-pushed
the
add-bip340-schnorr
branch
from
4f6699c to
8bc9587
Compare
…symb2 redo fuzz target
Fix link_name for secp256k1_ec_seckey_negate
There is little reason to pull in the `rand` dep just for the `Rng` trait for users who want to randomize contexts. We should expose a randomize function that just takes 32 bytes.
Add ability to randomize context without the `rand` feature.
update libsecp, remove endomorphism feature flag and release 0.20.0
…zz-feature Rename `rust_secp_fuzz` config flag to `fuzzing`
Signed-off-by: Gregory Hill <[email protected]>
use core instead of std for wasm sanity checks
More standard derives for Error
Use CARGO_CFG_TARGET_ARCH instead TARGET in build.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds binding for ecdsa adaptor signature and schnorr signature from this secp256k1 branch.
First commit is mainly auto-generated code (plus some changes to the script that do the autogeneration).
Second commit are changes to secp256k1-sys
Third commit is the higher level layer adding the types and functions.