Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/use adaptor signatures #110

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Feature/use adaptor signatures #110

merged 3 commits into from
Oct 26, 2020

Conversation

Tibo-lg
Copy link
Collaborator

@Tibo-lg Tibo-lg commented Oct 22, 2020

Change to use adaptor signatures instead of punishment mechanism. This means:

  • No need for mutual closing anymore so no communication required after contract setup
  • Same CET on both sides

@Tibo-lg Tibo-lg requested a review from prunelsigma October 22, 2020 02:13
prunelsigma
prunelsigma suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@prunelsigma prunelsigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

docker-compose.yml Outdated Show resolved Hide resolved
integration-test/run-separate/run.sh Show resolved Hide resolved
src/browser/dlc/controller/DlcManager.ts Outdated Show resolved Hide resolved
src/browser/dlc/controller/DlcManager.ts Outdated Show resolved Hide resolved
src/browser/dlc/controller/DlcManager.ts Show resolved Hide resolved
src/browser/dlc/models/contract/MaturedContract.ts Show resolved Hide resolved
integration-test/run-separate/dlcManager.test.ts Show resolved Hide resolved
prunelsigma
prunelsigma approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@prunelsigma prunelsigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the Oracle docker image before merging

@Tibo-lg Tibo-lg force-pushed the feature/use-adaptor-signatures branch from 63698ff to 022c14c Compare October 26, 2020 06:22
@Tibo-lg Tibo-lg force-pushed the feature/use-adaptor-signatures branch from 022c14c to 06f4644 Compare October 26, 2020 06:37
@Tibo-lg Tibo-lg merged commit 4a6df5b into p2pderivatives:develop Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prunelsigma prunelsigma prunelsigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tibo-lg @prunelsigma