Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modify plugin #562

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Fix modify plugin #562

merged 5 commits into from
Jan 9, 2024

Conversation

kirillov6
Copy link
Collaborator

Fixes #561

@kirillov6 kirillov6 self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (7d1a963) 69.67% compared to head (b992453) 70.03%.
Report is 3 commits behind head on master.

❗ Current head b992453 differs from pull request most recent head 16108e2. Consider uploading reports for the commit 16108e2 to get more accurate results

Files Patch % Lines
cfg/substitution/substitution.go 87.86% 22 Missing and 11 partials ⚠️
cfg/config.go 82.85% 8 Missing and 4 partials ⚠️
pipeline/config.go 40.00% 4 Missing and 2 partials ⚠️
test/test.go 40.00% 2 Missing and 1 partial ⚠️
fd/file.d.go 50.00% 2 Missing ⚠️
plugin/action/modify/modify.go 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   69.67%   70.03%   +0.35%     
==========================================
  Files         109      111       +2     
  Lines       11414    11690     +276     
==========================================
+ Hits         7953     8187     +234     
- Misses       2976     3004      +28     
- Partials      485      499      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yaroslav Kirillov added 3 commits January 9, 2024 13:01
Copy link
Collaborator

@HeadHunter483 HeadHunter483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirillov6 kirillov6 merged commit 0581358 into master Jan 9, 2024
8 checks passed
@kirillov6 kirillov6 deleted the 561-fix-modify branch January 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect modify plugin
4 participants