Regex performance in mask plugin (ignored fields && common match regex) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryRomanov
force-pushed
the
regex-performance
branch
from
51ffaeb to
bc119d0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 69.59% 69.62% +0.03%
==========================================
Files 109 109
Lines 11383 11414 +31
==========================================
+ Hits 7922 7947 +25
- Misses 2978 2981 +3
- Partials 483 486 +3 ☔ View full report in Codecov by Sentry. |
HeadHunter483
approved these changes
Dec 14, 2023
DmitryRomanov
force-pushed
the
regex-performance
branch
from
5607333 to
960bc56
Compare
DmitryRomanov
force-pushed
the
regex-performance
branch
from
960bc56 to
8583fa5
Compare
vano144
approved these changes
Dec 19, 2023
DmitryRomanov
force-pushed
the
regex-performance
branch
from
e540ebb to
1ab6a2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here are two improvements for mask plugin: