Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse: Convert non-string json values to string to prevent file.d fall #357

Merged
merged 6 commits into from
May 22, 2023

Conversation

vadimalekseev
Copy link
Collaborator

Related with #356

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 70.60% and project coverage change: +0.64 🎉

Comparison is base (a40b94d) 64.78% compared to head (0cd8bd0) 65.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   64.78%   65.42%   +0.64%     
==========================================
  Files         102      103       +1     
  Lines        9975    10079     +104     
==========================================
+ Hits         6462     6594     +132     
+ Misses       3086     3039      -47     
- Partials      427      446      +19     
Impacted Files Coverage Δ
plugin/output/clickhouse/column_gen.go 21.42% <15.38%> (+2.06%) ⬆️
plugin/output/clickhouse/column_custom.go 52.19% <52.89%> (-0.80%) ⬇️
plugin/output/clickhouse/clickhouse.go 68.53% <63.63%> (-0.07%) ⬇️
plugin/output/clickhouse/column_insane.go 87.50% <87.50%> (ø)
e2e/file_clickhouse/clickhouse_file.go 100.00% <100.00%> (ø)
e2e/file_clickhouse/sample.go 100.00% <100.00%> (ø)
plugin/output/clickhouse/infer.go 63.82% <100.00%> (+7.50%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vadimalekseev vadimalekseev changed the title Convert non-string json values to string to prevent file.d fall Clickhouse: Convert non-string json values to string to prevent file.d fall May 18, 2023
@vadimalekseev vadimalekseev force-pushed the 356-support-ch-json branch from 0d89c8a to 8d487b4 Compare May 18, 2023 14:13
@vadimalekseev vadimalekseev force-pushed the 356-support-ch-json branch from 8d487b4 to 0587c0c Compare May 18, 2023 14:14
@vadimalekseev vadimalekseev force-pushed the 356-support-ch-json branch from 0587c0c to e9a8227 Compare May 18, 2023 14:16
@vadimalekseev vadimalekseev force-pushed the 356-support-ch-json branch from aed89a2 to 7af8fb5 Compare May 22, 2023 08:51
@vadimalekseev vadimalekseev merged commit ed11b8b into master May 22, 2023
@vadimalekseev vadimalekseev deleted the 356-support-ch-json branch May 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants