Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split plugin #299

Merged
merged 29 commits into from
Nov 24, 2023
Merged

Split plugin #299

merged 29 commits into from
Nov 24, 2023

Conversation

vadimalekseev
Copy link
Collaborator

Fixes #293

@vadimalekseev vadimalekseev force-pushed the 293-split-plugin branch 2 times, most recently from 2d69deb to 7ec3fd9 Compare February 9, 2023 12:42
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (beb2d16) 67.86% compared to head (16c752b) 68.72%.
Report is 2 commits behind head on master.

❗ Current head 16c752b differs from pull request most recent head f7c2948. Consider uploading reports for the commit f7c2948 to get more accurate results

Files Patch % Lines
plugin/action/split/split.go 55.26% 12 Missing and 5 partials ⚠️
pipeline/processor.go 81.25% 6 Missing ⚠️
pipeline/event.go 69.23% 4 Missing ⚠️
plugin/action/move/move.go 95.16% 2 Missing and 1 partial ⚠️
plugin/output/gelf/gelf.go 0.00% 3 Missing ⚠️
e2e/split_join/split_join.go 97.36% 2 Missing ⚠️
plugin/output/elasticsearch/elasticsearch.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   67.86%   68.72%   +0.85%     
==========================================
  Files         104      108       +4     
  Lines       10705    10960     +255     
==========================================
+ Hits         7265     7532     +267     
+ Misses       2977     2955      -22     
- Partials      463      473      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vadimalekseev vadimalekseev changed the title Implement remap plugin Remap plugin Feb 10, 2023
@vadimalekseev vadimalekseev force-pushed the 293-split-plugin branch 3 times, most recently from aed744a to cd0d309 Compare February 17, 2023 13:00
pipeline/batch.go Outdated Show resolved Hide resolved
pipeline/processor.go Outdated Show resolved Hide resolved
@vadimalekseev vadimalekseev changed the title Remap plugin Split plugin Mar 3, 2023
pipeline/processor.go Outdated Show resolved Hide resolved
func (p *Plugin) Do(event *pipeline.Event) pipeline.ActionResult {
node := event.Root.Dig(p.config.Field_...)
if !node.IsArray() {
p.logger.Warn("skip an event because is not an array", zap.String("type", node.TypeStr()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because field is not an array

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pipeline/processor.go Outdated Show resolved Hide resolved
@vadimalekseev vadimalekseev merged commit 54cf379 into master Nov 24, 2023
6 of 7 checks passed
@vadimalekseev vadimalekseev deleted the 293-split-plugin branch November 24, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Split array of objects into Events
5 participants