Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized Unit Tests (Resolved Issue #3) #24

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Conversation

ozguraslank
Copy link
Owner

Explanation

Optimized the unit tests in the library. Resolved Issue #3

Supervised Experiment's Unit Tests (test_regression & test_classification)

  • test_regression and test_classification is combined to test_supervised.
  • exp_size will be "wide" only since trying "quick" and "wide" seperately makes no difference
  • Speed up to 2-3X

Cross Validation Unit Tests

  • n_folds and group amount are decrased from 5 to 3
  • test_size increased from 0.20 to 0.25
  • Removed unnecessary param definitions in certain cv methods
  • Speed up to 20-50%

test_ml_models Unit Tests

  • Removed poly kernel from SVC model's default tuning_param_grid since poly kernel takes too much time to finish
  • Combined test_classification_ml_models and test_regression_ml_models unit tests into one function to avoid duplications

* test_regression and test_classification is combined to test_supervised.
* exp_size will be "wide" only since trying "quick" and "wide" seperately makes no difference
* Speed up to 2-3X
* n_folds and group amount are decrased from 5 to 3
* test_size increased from 0.20 to 0.25
* Removed unnecessary param definitions in certain cv methods
* Speed up to 20-50%
* Removed poly kernel from SVC model's default tuning_param_grid since poly kernel takes too much time to finish
* Combined test_classification_ml_models and test_regression_ml_models unit tests into one function to avoid duplications
@ozguraslank ozguraslank added the optimization Speed and Code optimization label Jan 1, 2025
@ozguraslank ozguraslank added this to the 1.1.0 milestone Jan 1, 2025
@ozguraslank ozguraslank self-assigned this Jan 1, 2025
@ozguraslank ozguraslank merged commit f5a9e48 into main Jan 1, 2025
4 checks passed
@ozguraslank ozguraslank deleted the optimize_tests branch January 15, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Speed and Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant