Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(lexer): reorder imports #8290

Merged
merged 1 commit into from
Jan 6, 2025
Merged

style(lexer): reorder imports #8290

merged 1 commit into from
Jan 6, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 6, 2025 •
edited
Loading

Re-order imports in lexer.

@overlookmotel overlookmotel mentioned this pull request Jan 6, 2025
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Jan 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 6, 2025
Merged
Merged
Merged
Merged
Merged
Draft
@overlookmotel overlookmotel marked this pull request as ready for review January 6, 2025 13:21
@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 6, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8290 will not alter performance

Comparing 01-03-style_lexer_reorder_imports (4d2888d) with main (fabf116)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

Only affects code style, no substantive changes. So merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Jan 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 6, 12:33 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 12:33 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 12:39 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8289.
  • Jan 6, 12:39 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8289.
  • Jan 6, 12:57 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 1:10 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 1:16 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 6, 2:52 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 2:58 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 3:07 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
@overlookmotel overlookmotel force-pushed the 01-06-refactor_lexer_replace_allow_with_expect_ branch from 13132d7 to 3d95e0d Compare January 6, 2025 17:56
@overlookmotel overlookmotel force-pushed the 01-03-style_lexer_reorder_imports branch from 76a5e21 to 6f246cc Compare January 6, 2025 17:57
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
@overlookmotel overlookmotel changed the base branch from 01-06-refactor_lexer_replace_allow_with_expect_ to graphite-base/8290 January 6, 2025 18:01
@graphite-app graphite-app bot changed the base branch from graphite-base/8290 to main January 6, 2025 18:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
@overlookmotel overlookmotel force-pushed the 01-03-style_lexer_reorder_imports branch from 6f246cc to dd0326b Compare January 6, 2025 19:51
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
@overlookmotel
style(lexer): reorder imports (#8290)
4d2888d 
Re-order imports in lexer.
@overlookmotel overlookmotel force-pushed the 01-03-style_lexer_reorder_imports branch from dd0326b to 4d2888d Compare January 6, 2025 19:58
@graphite-app graphite-app bot merged commit 4d2888d into main Jan 6, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 01-03-style_lexer_reorder_imports branch January 6, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel