Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer): elide lifetimes where possible #8285

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 6, 2025

Pure refactor. Enable clippy::needless_lifetimes lint rule in oxc_transformer, and fix what the rule flags - remove unnecessary lifetimes which can be elided.

Also rename a few lifetimes 'b and 'c to more descriptive 'ctx.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 6, 2025
@overlookmotel overlookmotel marked this pull request as ready for review January 6, 2025 11:40
@overlookmotel overlookmotel requested a review from Dunqing as a code owner January 6, 2025 11:40
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #8285 will not alter performance

Comparing 01-04-refactor_transformer_elide_lifetimes_where_possible (109b8fc) with main (e81f34f)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
Copy link
Member

Dunqing commented Jan 6, 2025

Merge activity

  • Jan 6, 9:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 9:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 9:56 AM EST: A user merged this pull request with the Graphite merge queue.

Pure refactor. Enable `clippy::needless_lifetimes` lint rule in `oxc_transformer`, and fix what the rule flags - remove unnecessary lifetimes which can be elided.

Also rename a few lifetimes `'b` and `'c` to more descriptive `'ctx`.
@Dunqing Dunqing force-pushed the 01-04-refactor_transformer_elide_lifetimes_where_possible branch from 4fa914c to 109b8fc Compare January 6, 2025 14:52
@graphite-app graphite-app bot merged commit 109b8fc into main Jan 6, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-04-refactor_transformer_elide_lifetimes_where_possible branch January 6, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants