refactor(ast)!: no unneccesary trailing underscores on AstBuilder method names
#8283
+24
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-ast
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8283 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jan 6, 2025
Merge activity
|
…ethod names (#8283) `AstBuilder` method names have an `_` added on end if method name is not a valid identifier (e.g. `super`). But no need for trailing underscore on `alloc_super`. Currently this only applies to `super`. But future-proof by checking against all Rust's reserved words. This is a breaking change, because `alloc_super` method was previously called `alloc_super_`. But probably no-one uses that method anyway - usually you'd use `expression_super` method to get an `Expression::Super`.
Dunqing
force-pushed
the
01-04-refactor_ast_astbuilder_enum_builder_methods_use_alloc__methods
branch
from
9bd7cde to
0db2a22
Compare
Dunqing
force-pushed
the
01-06-refactor_ast_no_unneccesary_trailing_underscores_on_astbuilder_method_names
branch
from
9c884f1 to
d8b27af
Compare
Base automatically changed from
01-04-refactor_ast_astbuilder_enum_builder_methods_use_alloc__methods
to
main
January 6, 2025 15:14
graphite-app
bot
deleted the
01-06-refactor_ast_no_unneccesary_trailing_underscores_on_astbuilder_method_names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AstBuildermethod names have an_added on end if method name is not a valid identifier (e.g.super). But no need for trailing underscore onalloc_super.Currently this only applies to
super. But future-proof by checking against all Rust's reserved words.This is a breaking change, because
alloc_supermethod was previously calledalloc_super_. But probably no-one uses that method anyway - usually you'd useexpression_supermethod to get anExpression::Super.