Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fix_deps to recursively fix all dependencies #819

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

bigbeno37
Copy link

Update fix_deps to recursively fix all dependencies

Package(s)

  • GUI
  • CLI
  • Core
  • None

Description

This updates the fix_deps function in the validate.rs area of the core to recursively identify and resolve any missing dependencies. The implementation isn't actually recursive, but rather uses a VecDeque to store mods to be validated, starting with the mod provided as the parameter.

@Bwc9876
Copy link
Member

Bwc9876 commented Dec 14, 2024

The only concern I may have is what if we have a structure like this?

graph TD
	A[A, Installed] --> B[B, Not Installed]
	B --> C[C, Not Installed]
	C --> B
Loading

At least to me it seems like this could get stuck in an infinite loop, while mod developers should never do this we still try to prevent a scenario where a mod developer can freeze up the manager in such a way with an ill-formed manifest(s).

@Bwc9876
Copy link
Member

Bwc9876 commented Dec 14, 2024

Preferably we could create a test to make sure it doesn't

@Bwc9876 Bwc9876 changed the base branch from tauri-v2 to dev December 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants