Fix linter errors

[mike-gregory-ovo]

The latest version of golangci-lint makes some critical changes to the linters, so I've fixed the various errors across multiple files.

[github-actions]

Test Results

196 tests   196 ✔️  10s ⏱️
  14 suites      0 💤
    1 files        0 ❌

Results for commit b3f330c.

♻️ This comment has been updated with latest results.

[jlucktay]

I'm concerned about secrets being leaked through errors and logs and the like.
Apart from that, though, overall good refactor. 👍

[mike-gregory-ovo]

Hey @jlucktay, those are the names of the expected configuration key e.g. SlackAPIKey is https://github.com/ovotech/go-sync/blob/fix-linter-errors/adapters/slack/usergroup/usergroup.go#L56-L59. The ErrorContains is just to ensure that the error contains the name of the key that's failing.

[jlucktay]

Hey @jlucktay, those are the names of the expected configuration key e.g. SlackAPIKey is https://github.com/ovotech/go-sync/blob/fix-linter-errors/adapters/slack/usergroup/usergroup.go#L56-L59. The ErrorContains is just to ensure that the error contains the name of the key that's failing.

OK, good to know. Those variable names are really alarming in isolation. Even that comment makes me think twice:

SlackAPIKey is an API key for authenticating with Slack.

To me, that reads like it's describing the secret itself, not the key to look up the secret in another thing somewhere else.

[mike-gregory-ovo]

Agreed, bad naming on my behalf. I'm going to leave as-is for now as I imagine this will all change when we move to goplugins anyway!