Fix Slack usergroup adapter #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed the linting for the Slack usergroup adapter but the version of |
mike-gregory-ovo
approved these changes
Dec 14, 2023
chris-brindley
force-pushed
the
NOJIRA/fix-slack-usergroups
branch
from
06e054a to
48b581a
Compare
|
@mike-gregory-ovo I have rebased and force-pushed, should be okay for a re-review now 👍 |
mike-gregory-ovo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Slack usergroup adapter that was causing issues when adding and removing users from a group in a single operation.
The
AddandRemovemethods rely on internal state of the adapter to understand what user IDs are to be sent to the API. This internal state is only updated on theGetmethod, not theAddorRemovemethods. Thus, when callingAddand subsequentlyRemove(or vice-versa), the state is wrong and the adapter sends an incorrect set of IDs to the Slack API. This resulted is buggy behaviour causing users to be added and removed in quick succession.