Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function and comments errors #477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix function and comments errors #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f8694
Ownable2StepUpgradeable.sol
intls Jan 19, 2025
e07e3b8
ZoraCreator1155Factory.t.sol
intls Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/1155-contracts/src/utils/ownable/Ownable2StepUpgradeable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ abstract contract Ownable2StepUpgradeable is IOwnable2StepUpgradeable, IOwnable2
}

/// @notice Resign ownership of contract
/// @dev only callably by the owner, dangerous call.
/// @dev only callable by the owner, dangerous call.
function resignOwnership() public onlyOwner {
_transferOwnership(address(0));
}
Expand Down
8 changes: 4 additions & 4 deletions packages/1155-contracts/test/factory/ZoraCreator1155Factory.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ contract ZoraCreator1155FactoryTest is Test {
string calldata nameA,
string calldata uri,
address contractAdmin,
// this number will determine how transactions the factory makes before
// this number will determine how many transactions the factory makes before
// creating the deterministic contract. it should not affect the address
uint16 numberOfCallsBeforeCreation
) external {
Expand Down Expand Up @@ -211,7 +211,7 @@ contract ZoraCreator1155FactoryTest is Test {
string calldata nameA,
string calldata uri,
address contractAdmin,
// this number will determine how transactions the factory makes before
// this number will determine how many transactions the factory makes before
// creating the deterministic contract. it should not affect the address
uint16 numberOfCallsBeforeCreation
) external {
Expand Down Expand Up @@ -245,7 +245,7 @@ contract ZoraCreator1155FactoryTest is Test {
string calldata nameA,
string calldata uri,
address contractAdmin,
// this number will determine how transactions the factory makes before
// this number will determine how many transactions the factory makes before
// creating the deterministic contract. it should not affect the address
uint16 numberOfCallsBeforeCreation
) external {
Expand Down Expand Up @@ -318,7 +318,7 @@ contract ZoraCreator1155FactoryTest is Test {
assertEq(createdAddress, expectedContractAddress);
}

function test_createContractDeterministic_createdContractcontractCanBeUpgraded() external {
function test_createContractDeterministic_createdContractCanBeUpgraded() external {
string memory uri = "ipfs://asdfadsf";
string memory nameA = "nameA";
address contractAdmin = vm.addr(1);
Expand Down