Add backend test framework template #475
Conversation
mishayouknowme
force-pushed
the
michaelpopov1/pla-256-add-backend-test-framework-template
branch
2 times, most recently
from
e058aae to
9c5754a
Compare
|
Please, rebase into the main branch as there are plenty of changes accumulated. |
src/backend-test/index.ts
Outdated
|
|
||
| // ANCHOR ESLint and prettier setup | ||
|
|
||
| const lintPaths = options.lintPaths ?? ['.projenrc.ts', '.'] |
There was a problem hiding this comment.
Why wouldn't you include explicitly the patterns you want to check and instead includes everything? I'm not sure we should use the format command on all the projen-generated files. For now I did not find any conflicts when the command is run. Though there is no guarantee for the future, as we can change/add our rules which could contradict what projen renders.
There was a problem hiding this comment.
Sorry, it's not completely clear to me what you mean by including explicitly the patterns. Currently, I am not passing the projenrc file to the addLinters and just using [.] it will be enough?
There was a problem hiding this comment.
By include explicitly the patterns you want I mean getting rid of . and manually list the files and folders you want to format/check. Thus you would have the same list defined for both eslint and prettier. On the other hand with . you have all files processed (even the readme) and if anything needs be excluded one must handle separate ignore lists for prettier and eslint.
However I don't insist. If that's what you expect from the project, then I'm ok with it. Maybe @bdoof has any comment on it.
src/backend-test/index.ts
Outdated
| }) | ||
|
|
||
| // ANCHOR ESLint and prettier setup | ||
|
|
src/backend-test/index.ts
Outdated
|
|
||
| // ANCHOR ESLint and prettier setup | ||
|
|
||
| const lintPaths = options.lintPaths ?? ['.projenrc.ts', '.'] |
There was a problem hiding this comment.
By include explicitly the patterns you want I mean getting rid of . and manually list the files and folders you want to format/check. Thus you would have the same list defined for both eslint and prettier. On the other hand with . you have all files processed (even the readme) and if anything needs be excluded one must handle separate ignore lists for prettier and eslint.
However I don't insist. If that's what you expect from the project, then I'm ok with it. Maybe @bdoof has any comment on it.
|
@quesabe @mishayouknowme what's the status of this PR? How close are we to merging it? |
From my side I marked two minor issues (which do not stop us from merging):
I didn't check whether the changes requested by @bdoof are done - I expected him to verify and resolve the conversations he opened. Overall we seem to be very close to the end line. Just need to coordinate the remaining concerns. And final point: I'd prefer all the commits to be squashed before merging. Otherwise we'll get a lot of irrelevant historical info in the main branch. |
|
I think |
|
@quesabe @mishayouknowme are we good to merge it? |
quesabe
deleted the
michaelpopov1/pla-256-add-backend-test-framework-template
branch
No description provided.