Skip to content

Commit

Permalink
PLA-317 Fall back to NodeJS@16 in publish action
Browse files Browse the repository at this point in the history
Somehow v20 does not bundle dependencies, which causes the package to fail to bootstrap any project
  • Loading branch information
quesabe committed May 31, 2024
1 parent 0d0f235 commit 2905c0d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish-release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ publishReleaseGithubWorkflow.addJobs({
'registry-url': 'https://registry.npmjs.org/',
'npm-token': '${{ secrets.NPM_TOKEN }}',
'include-build-step': true,
// FIXME: v16 is a workaround with the problem revealed on v20: deps are not bundled upon publish.
'node-version': 16,
},
},
]),
Expand Down

0 comments on commit 2905c0d

Please sign in to comment.