Update dependencies #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quesabe
force-pushed
the
update-actions-version
branch
from
a676260 to
2b6978d
Compare
quesabe
force-pushed
the
update-actions-version
branch
from
2b6978d to
4576905
Compare
gvidon
reviewed
Apr 29, 2024
| @@ -19,12 +19,12 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [16.x] | |||
| node-version: [16.x, 20.x] | |||
There was a problem hiding this comment.
@quesabe why not keeping just 20?
There was a problem hiding this comment.
I was not confident the version 16 is not used anywhere downstream. Hence I left the check to ensure the actions still work with node@16.
If you believe we can drop any support for old versions, I can remove v16 and in the future save some resources on these tests.
gvidon
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PLA-312.