Charms #4614
Closed
Charms #4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillhioreBT
reviewed
Dec 25, 2023
data/lib/core/player.lua
Outdated
| @@ -737,3 +742,37 @@ function Player.disableLoginMusic(self) | |||
| msg:delete() | |||
| return true | |||
| end | |||
|
|
|||
| function Player.isCharmUnlocked(self, charmId) | |||
| if self:getStorageValue(PlayerStorageKeys.charmsUnlocked + charmId) == 1 then | |||
There was a problem hiding this comment.
Storages now return nil if empty, doing a direct check with a number is wrong
There was a problem hiding this comment.
that is why this PR is on draft, i porting it from my personal project to TFS
ghost
requested review from
ghost
added
the
ranisalt
reviewed
Dec 27, 2023
|
|
||
| if kills < bestiaryInfo.mastery and newKills >= bestiaryInfo.mastery then | ||
| self:addCharmPoints(bestiaryInfo.charmPoints) | ||
| end |
There was a problem hiding this comment.
Can this be added to unlockCharm (and removeCharm) instead?
3 tasks
ranisalt
reviewed
Apr 11, 2024
Comment on lines
+751
to
+756
| function Player.isCharmUnlocked(self, charmId) | ||
| if (self:getStorageValue(PlayerStorageKeys.charmsUnlocked + charmId) or 0) == charmStatus.UNLOCKED then | ||
| return charmStatus.UNLOCKED | ||
| end | ||
| return charmStatus.LOCKED | ||
| end |
There was a problem hiding this comment.
Would
Suggested change
| function Player.isCharmUnlocked(self, charmId) | |
| if (self:getStorageValue(PlayerStorageKeys.charmsUnlocked + charmId) or 0) == charmStatus.UNLOCKED then | |
| return charmStatus.UNLOCKED | |
| end | |
| return charmStatus.LOCKED | |
| end | |
| function Player.isCharmUnlocked(self, charmId) | |
| return self:getStorageValue(PlayerStorageKeys.charmsUnlocked + charmId) or charmStatus.LOCKED | |
| end |
work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Introduction of the charm system(offensive perks + dodge)
#3871 issue