Skip to content

Commit

Permalink
test command-line: remove unnecessary encoding logic
Browse files Browse the repository at this point in the history
GitHub: ref groongaGH-2172

Issue

When running grndb tests in a Windows environment, encoding file paths
containing Japanese characters failed in the test logs. It caused tests to
fail.

Cause

This issue occurred because log file encoded in UTF-8 were
misinterpreted as CP932 and then converted to UTF-8.

Soulution

Groonga logs are originally in UTF-8 so we don't have to convert.
We just remove the encodeing logic from test's helper.
  • Loading branch information
otegami committed Jan 16, 2025
1 parent 74628ea commit 51122d6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/command_line/helper/groonga_log.rb
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def groonga_log_content
end

def normalized_groonga_log_content
normalize_groonga_log(groonga_log_content).encode("locale")
normalize_groonga_log(groonga_log_content)
end

private
Expand Down

0 comments on commit 51122d6

Please sign in to comment.