Fix problems from async build process #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were causing nested tokio runtime panics when calling `build()` from `deploy()`. All of the callers are async functions anyway, so these can be true async functions now. Signed-off-by: Robert Detjens <[email protected]>
This is cleaner than needing to wrap the whole iterator in a call to futures::try_join_all(). Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
detjensrobert
force-pushed
the
dr/async-build-fixes
branch
from
c532d00 to
701af61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deploycommand needs to callbuild, and this was causing problems with nested Tokio runtimes. This fixes the problem by making the last bits of the build process (artifact extraction) properly async instead of blocking with#[tokio::main].This exposed a couple other problems from running artifacts in 'parallel'; asset containers can have name collisions. This adds a new dependency
fastrandto create a discriminator to prevent collisions. (Rust does not have rand generation in the stable stdlib yet.)Additionally, I added an
Iteratortrait to usefutures::try_join_all()as a chained method instead of a wrapper. This makes awaiting many futures cleaner to follow.