-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ implement ListContributors
for Azure DevOps
#4437
✨ implement ListContributors
for Azure DevOps
#4437
Conversation
Signed-off-by: Jamie Magee <[email protected]>
The Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Contributors check now passes. Albeit with unexpected results, as I'm not sure what to choose for Companies or Organizations.
It may be difficult to get meaningful data for this check since everything is inherently contained in a single organization?
Signed-off-by: Jamie Magee <[email protected]>
Exactly. It also returns nonsensical results for imported repositories. A better check might be using email domain to determine organization association. What do you think? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
==========================================
+ Coverage 66.80% 68.52% +1.71%
==========================================
Files 230 241 +11
Lines 16602 17938 +1336
==========================================
+ Hits 11091 12292 +1201
- Misses 4808 4843 +35
- Partials 703 803 +100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better check might be using email domain to determine organization association. What do you think?
This was also suggested in #4415 for GitLab, let's talk about this tomorrow Thursday at the community meeting.
What kind of change does this PR introduce?
Feature
What is the current behavior?
LisContributors
throws an unsupported error on Azure DevOpsWhat is the new behavior (if this is a feature change)?**
LisContributors
is implemented for Azure DevOpsWhich issue(s) this PR fixes
Next step of #4177
Special notes for your reviewer
I am a little unsure what to put for
Companies
orOrganizations
. For now, I've defaulted to the current Azure DevOps organization.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)