Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Provenance): Add a LocalProvenance sub-interface #9872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pepper-jk
Copy link
Contributor

@pepper-jk pepper-jk commented Jan 30, 2025

In contrast to the previously added RemoteProvenance stands the LocalProvenance, which has no remote source, but instead references a local input of some kind.

For more context on the new Provenance Hierarchy, see: #8803 (comment)

Signed-off-by: Jens Keim [email protected]

@pepper-jk pepper-jk requested a review from a team as a code owner January 30, 2025 15:55
@pepper-jk pepper-jk marked this pull request as draft January 30, 2025 16:03
model/src/main/kotlin/Provenance.kt Fixed Show fixed Hide fixed
model/src/main/kotlin/Provenance.kt Fixed Show fixed Hide fixed
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (8a3812c) to head (c0a51c2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9872   +/-   ##
=========================================
  Coverage     68.21%   68.21%           
  Complexity     1293     1293           
=========================================
  Files           250      250           
  Lines          8849     8849           
  Branches        920      920           
=========================================
  Hits           6036     6036           
  Misses         2424     2424           
  Partials        389      389           
Flag Coverage Δ
funTest-non-docker 33.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pepper-jk pepper-jk changed the title feat(Provenance): Add DirectoryProvenance as a LocalProvenance feat(Provenance): Add a LocalProvenance sub-interface Feb 3, 2025
@pepper-jk pepper-jk marked this pull request as ready for review February 3, 2025 13:21
@pepper-jk
Copy link
Contributor Author

@sschuberth failing tests seem unrelated.
Could you have a look and maybe restart them?
A review would be awesome as well.

In contrast to the previously added `RemoteProvenance` stands the
`LocalProvenance`, which has no remote source, but instead references
a local input of some kind.

See [1] for more context on the new Provenance Hierarchy.

[1]: oss-review-toolkit#8803 (comment)

Signed-off-by: Jens Keim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant