fix(Git): Work around a bug with JGit vs MINA #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bennati does this fix your use-case? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9856 +/- ##
=========================================
Coverage 68.12% 68.12%
Complexity 1292 1292
=========================================
Files 250 250
Lines 8840 8840
Branches 917 917
=========================================
Hits 6022 6022
Misses 2431 2431
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -104,6 +104,9 @@ class Git( | |||
| ) : VersionControlSystem() { | |||
| companion object { | |||
| init { | |||
| // Work around a bug in Apache MINA sshd, see https://github.com/eclipse-jgit/jgit/issues/135. | |||
| System.setProperty("java.security.egd", "file:/dev/./urandom") | |||
There was a problem hiding this comment.
Should this only be executed if the OS is Linux?
There was a problem hiding this comment.
Good point, done, and added an explanation to the commit message.
Also see [1] for some more background information about why SSH connections can otherwise block "if there is less entropy available than requested". As a safety measure, this is only done on Linux to not cause any unintended slow-down on Windows, also see [2]. [1]: https://stackoverflow.com/a/59097932/1127485 [2]: https://www.baeldung.com/java-security-egd#testing-the-effect-of-javasecurityegd Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
jgit-vs-mina
branch
from
7eff0db to
b4f6769
Compare
mnonnenmacher
approved these changes
Jan 30, 2025
fviernau
approved these changes
Jan 30, 2025
|
Merging this early for the release as previous checks passed and only a trivial condition (famous last words) was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see 1 for some more background information about why SSH connections can otherwise block "if there is less entropy available than requested".