Migrate scanner plugins to new plugin API #9837
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "fast, accurate, and to support a wide variety of license texts.", | ||
| factory = ScannerWrapperFactory::class | ||
| ) | ||
| class Askalono( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| "are under.", | ||
| factory = ScannerWrapperFactory::class | ||
| ) | ||
| class BoyterLc( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| description = "Licensee is a command line tool to detect licenses in a given project.", | ||
| factory = ScannerWrapperFactory::class | ||
| ) | ||
| class Licensee( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
|
|
||
| data class ScanCodeConfig( | ||
| /** | ||
| * Command line options that modify the result. These are added to the [ScannerDetails] when looking up results from | ||
| * a [ScanStorage]. Defaults to [ScanCodeConfig.DEFAULT_COMMAND_LINE_OPTIONS]. |
Check warning
Code scanning / QDJVMC
Unresolved reference in KDoc Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9837 +/- ##
============================================
- Coverage 68.21% 68.17% -0.04%
Complexity 1293 1293
============================================
Files 250 250
Lines 8849 8849
Branches 920 920
============================================
- Hits 6036 6033 -3
- Misses 2424 2428 +4
+ Partials 389 388 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnonnenmacher
force-pushed
the
scanner-plugins
branch
from
f83b7ba to
2873874
Compare
Refactor scanner plugins to not inherit from `CommandLineTool` and move the `CommandLineTool` implementations to separate objects. Also rename `CommandLinePathScannerWrapper` to `LocalPathScannerWrapper`. This provides better separation of concerns and helps with the upcoming migration of scanner plugins to the new plugin API, because with that the scanner plugins will not have empty constructors anymore which are required by the `RequirementsCommand` to list required command line tools. Signed-off-by: Martin Nonnenmacher <[email protected]>
The code has become obsolete because since 3cfe66e the VCS plugins do not implement `CommandLineTool` anymore. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
scanner-plugins
branch
from
2873874 to
4408c7e
Compare
Migrate the `ScannerWrapper` plugins to the new plugin API. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
scanner-plugins
branch
from
4408c7e to
481b5d0
Compare
Not ready for review, created to get an overview of test results.