Various Webapp fixes and new features #9804
Open
+4,843
−5,563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Steenbergen <[email protected]>
Update dependencies to latest available versions to benefit from upstream improvements. React is not updated to newer than version 18 due to Ant Design and React 19 compatibility issues [1]. [1]: https://ant.design/docs/react/v5-for-19 Signed-off-by: Thomas Steenbergen <[email protected]>
Signed-off-by: Thomas Steenbergen <[email protected]>
tsteenbe
force-pushed
the
webapp-fixes-updates
branch
from
540ecc2 to
b02b978
Compare
In preparation for upcoming React state handling change where these functions will be used. Signed-off-by: Thomas Steenbergen <[email protected]>
Remove unused variables and align title variable with the way other variables are implemented. Signed-off-by: Thomas Steenbergen <[email protected]>
For unclear reasons the licenseSource property function was not implemented when this class was originally written. Signed-off-by: Thomas Steenbergen <[email protected]>
Add detectedLicensesProcessedIndexes function to enable retrieving the indexes for detected licenses in the EvaluatedModel that are not excluded. Signed-off-by: Thomas Steenbergen <[email protected]>
Add several helper functions that make it easier to debug data issues within the WebApp. Signed-off-by: Thomas Steenbergen <[email protected]>
After upgrading to the latest version of Ant Design many entries in the CSS were no longer needed and others could be improved to reduce time needed by the browser to process the CSS file. Signed-off-by: Thomas Steenbergen <[email protected]>
Add new background SVG which will be used in future React state handling change. Signed-off-by: Thomas Steenbergen <[email protected]>
Replace Redux [1] with React own state handling [2] to: 1) State handling per instance of a component possible 2) It easier for new contributors to contribute This is a breaking change as it's no longer possible to step through the Tree search results. This functionality will hopefully be restore in a future change. [1]: https://redux.js.org/ [2]: https://react.dev/learn/managing-state Signed-off-by: Thomas Steenbergen <[email protected]>
Remove unused code after refactoring in previous change. Signed-off-by: Thomas Steenbergen <[email protected]>
Fix up issue table to show the source of technical issue e.g. whether it comes from say NPM or ScanCode. Fixes #8211. Signed-off-by: Thomas Steenbergen <[email protected]>
Enable filtering of scanner findings by file path, start or end lines to help speed up finding entries related to a ORT policy rule violation. Fixes #5130. Signed-off-by: Thomas Steenbergen <[email protected]>
Replace vulnerability ratings icons with tags so their more distinguishable and quicker to understand. Fixes #8808. Signed-off-by: Thomas Steenbergen <[email protected]>
Fixes #8038. Signed-off-by: Thomas Steenbergen <[email protected]>
tsteenbe
force-pushed
the
webapp-fixes-updates
branch
from
b02b978 to
d585f1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9804 +/- ##
============================================
+ Coverage 68.07% 68.14% +0.07%
- Complexity 1284 1290 +6
============================================
Files 249 249
Lines 8827 8847 +20
Branches 918 918
============================================
+ Hits 6009 6029 +20
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.
This PR has been months in the making - by rewriting the WebApp to use React native state handling I was able to finally implement some long open issues. This is part 1 of 2 once this is merge follow up PR to fix a second batch of issues reported against the WebApp reporter.