clients/osv: Reduce fun test flakyness #9773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
osv-client-fun-test-flakyness-fix-1
branch
from
63d5e04 to
d8d90f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9773 +/- ##
=========================================
Coverage 68.07% 68.07%
Complexity 1284 1284
=========================================
Files 249 249
Lines 8827 8827
Branches 918 918
=========================================
Hits 6009 6009
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
Jan 17, 2025
| @@ -0,0 +1,47 @@ | |||
| { | |||
There was a problem hiding this comment.
Commit message: Typo in "cchanges".
The function actually does two things, patching ignorable fields and normalize this. So, rename the function to just `patch()` so that it better fits also the normalization and uses a shorter name. Signed-off-by: Frank Viernau <[email protected]>
Relax the assertion to only check that a single expected vulnerability is amongst the actually returned ones. Use the (only) vulnerability which had been returned back when OSV was introduced, in July 2022. In these ~2.5 years the vulnerability changed only in terms of the schema version. As the schema version changes are not very frequent, this likely reduces flakyness. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
osv-client-fun-test-flakyness-fix-1
branch
from
d8d90f3 to
34fa5fc
Compare
sschuberth
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces flakyness of the first test. PRs for the other tests will follow.
Note: Using
shouldEqualJsonfor this job does not work, because it does not support a comparision mode whichcompares JSON arrays by
containsAll(subset).