Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing whitespace to all "BlackDuck" occurences #9737

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Jan 14, 2025

Part of #8739.

@fviernau fviernau requested a review from a team as a code owner January 14, 2025 08:17
@fviernau fviernau enabled auto-merge (rebase) January 14, 2025 08:17
@fviernau fviernau force-pushed the docs-black-duck-spelling branch from 7dd28d8 to 8931107 Compare January 14, 2025 08:18
@@ -40,7 +40,7 @@ internal class ResponseCachingComponentServiceClient(
private val serverUrl: String?,
apiToken: String?
) : ComponentServiceClient {
// The BlackDuck library uses GSON to serialize its POJOs. So use GSON, too, because this is the simplest option.
// The Black Duck library uses GSON to serialize its POJOs. So use GSON, too, because this is the simplest option.
Copy link
Member

@sschuberth sschuberth Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message nit: Some hint / reference about the official spelling would have been nice, like linking to https://www.blackduck.com/company.html. Because interestingly, while in the logo it looks like one word, in prose text they spell themselves indeed as "Black Duck".

@sschuberth sschuberth disabled auto-merge January 14, 2025 08:24
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (a032f27) to head (ccc6c10).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9737      +/-   ##
============================================
- Coverage     68.09%   67.89%   -0.21%     
+ Complexity     1294     1293       -1     
============================================
  Files           249      249              
  Lines          8846     8871      +25     
  Branches        923      930       +7     
============================================
- Hits           6024     6023       -1     
- Misses         2433     2459      +26     
  Partials        389      389              
Flag Coverage Δ
funTest-docker 65.02% <ø> (-0.07%) ⬇️
funTest-non-docker 33.30% <ø> (ø)
test-ubuntu-24.04 35.91% <ø> (+0.02%) ⬆️
test-windows-2022 35.89% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau force-pushed the docs-black-duck-spelling branch from 8931107 to ccc6c10 Compare January 14, 2025 08:38
@fviernau fviernau enabled auto-merge (rebase) January 14, 2025 08:39
@fviernau fviernau merged commit 1d9f415 into main Jan 14, 2025
25 of 26 checks passed
@fviernau fviernau deleted the docs-black-duck-spelling branch January 14, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants