Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper-cli): Add a default value for Dependency.purl #9573

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Dec 10, 2024

The recent addition of dependency.purl [1] made providing that purl mandatory. That should have been optional so that the change is non-breaking. Fix that by adding a default value.

[1] b1a157d

Related to: #8739.

The recent addition of `dependency.purl` [1] made providing that `purl`
mandatory. That should have been optional so that the change is
non-breaking. Fix that by adding a default value.

[1] b1a157d

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau requested a review from a team as a code owner December 10, 2024 09:00
@fviernau fviernau enabled auto-merge (rebase) December 10, 2024 09:00
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (097eb5d) to head (9486c9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9573      +/-   ##
============================================
+ Coverage     68.01%   68.02%   +0.01%     
  Complexity     1291     1291              
============================================
  Files           249      249              
  Lines          8822     8822              
  Branches        917      917              
============================================
+ Hits           6000     6001       +1     
+ Misses         2433     2432       -1     
  Partials        389      389              
Flag Coverage Δ
funTest-docker 64.89% <ø> (ø)
funTest-non-docker 33.31% <100.00%> (+0.01%) ⬆️
test 35.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau merged commit 29a6384 into main Dec 10, 2024
23 checks passed
@fviernau fviernau deleted the helper-cli-package-list-purl-default-value-fix branch December 10, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants