Enhance Key Preview on Press #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: 1. https://github.com/LineageOS/android_packages_inputmethods_LatinIME/blob/lineage-21.0/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewChoreographer.java 2. https://github.com/LineageOS/android_packages_inputmethods_LatinIME/blob/lineage-21.0/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewView.java
|
LGTM on emulator Screen_recording_20241201_173612.mp4 |
|
Weird
|
|
@Bambooin I cannot reproduce too. Debug version is always a little laggy, we may no need to worry about it. |
Bambooin
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
In this PR, key preview on press gets enhanced. And more code cleanup BTW.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info