Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 输入状态下切换深色模式时，悬浮窗无法关闭 #1420

Merged
merged 1 commit into from
Jul 7, 2024
Merged

fix: 输入状态下切换深色模式时，悬浮窗无法关闭 #1420

merged 1 commit into from
Jul 7, 2024

Conversation

nopdan
Copy link
Contributor

@nopdan nopdan commented Jul 4, 2024

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1419
Fixes #

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck
Copy link
Collaborator

@nopdan 这个问题，在 onConfigurationChanged 中 clearComposition 之后，在 withContext(Dispatchers.Main) 下 updateComposing 一下或可解，还麻烦测试一下

@WhiredPlanck WhiredPlanck merged commit 9a5d296 into osfans:develop Jul 7, 2024
4 checks passed
@nopdan nopdan mentioned this pull request Jul 12, 2024
Merged
5 tasks
@nopdan nopdan deleted the fix-1419 branch July 12, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhiredPlanck WhiredPlanck WhiredPlanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

输入状态下切换深色模式时，悬浮窗无法关闭
2 participants
@nopdan @WhiredPlanck