Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work with the old synced asset files hierarchy #1364

Merged
merged 1 commit into from
May 10, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

After #1359 , the assets will actually copy to <shared_directory>/rime/... while <shared_directory>/... is the original hierarchy. This PR is to fix to work with the old way.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck requested review from goofyz and Bambooin May 7, 2024 21:15
@WhiredPlanck WhiredPlanck merged commit 46cd745 into osfans:develop May 10, 2024
4 checks passed
@WhiredPlanck WhiredPlanck deleted the data-fix branch May 10, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants