-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Day 2 documentation #5
base: master
Are you sure you want to change the base?
Conversation
By shaket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move webdev-day2.md
which is at the root of the directory to fromScratch/WebDev-Bootcamp
and rename file to match the current format.
Or add contents of the current markdown file to the existing fromScratch/WebDev-Bootcamp/WebDev-Bootcamp.md
file by adding a new header with the title Day 2
.
PR will be merged after the requested changes are made.
webdev-day2.md
Outdated
The main idea behind the flex layout is to give the container the ability to alter its items’ width/height (and order) to best fill the available space (mostly to accommodate to all kind of display devices and screen sizes). A flex container expands items to fill available free space or shrinks them to prevent overflow. | ||
|
||
<details> | ||
<summary>Basics and terminology</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the idea of adding
is neat, it breaks inner alignment. Resorting to using a H3 (###
) should be enough.
webdev-day2.md
Outdated
<br> | ||
<br> | ||
|
||
[In depth alignments guide](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Aligning_Items_in_a_Flex_Container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webdev-day2.md
Outdated
|
||
+ | ||
</details> | ||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use markdown syntax. Switch from <br>
to \
.
@SVijayB please check the changes. |
@ojasva changes requested from the initial review is yet to do be done.
|
@ojasva status on this? |
on it sir, a bit occupied with labs and college environment for the first time, so pardon for delays please |
It's cool, no issues. Take your time xD |
@ojasva any updates on this yet? |
By shaket