Don't Panic in getComposeStatus and skip invalid jobs in fsjobqueue New #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This 'fixes' #3779 by ignoring broken job json files. The big question is what to do with them. Should they be removed? Moved to the side for later examination (and somehow expired before the filesystem fills up)? Or leave them in place (and fill up the filesystem eventually). |
schutzbot
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
|
Rebased to prevent OCI private key leaking. Apologies :( |
croissanne
force-pushed
the
main-dont-panic
branch
from
4aa137d to
bc93135
Compare
bcl
force-pushed
the
main-dont-panic
branch
4 times, most recently
from
6bdfce7 to
5ed1bc2
Compare
This handles corrupt job json files by skipping them. They still exist, and errors are logged, but the system keeps working. If one or more of the json files in /var/lib/osbuild-composer/jobs/ becomes corrupt they can stop the osbuild-composer service from starting, or stop commands like 'composer-cli compose status' from working because they quit on the first error and miss any job that aren't broken.
ondrejbudai
force-pushed
the
main-dont-panic
branch
from
70b47fc to
529f0f7
Compare
ondrejbudai
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles corrupt job json files by skipping them. They still exist, and errors are logged, but the system keeps working.
If one or more of the json files in /var/lib/osbuild-composer/jobs/ becomes corrupt they can stop the osbuild-composer service from starting, or stop commands like 'composer-cli compose status' from working because they quit on the first error and miss any job that aren't broken.
This pull request includes: