Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizrad: add validation to ssh key field (HMS-5349) #2794

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mgold1234
Copy link
Collaborator

this commit add validation to ssh key field

JIRA: HMS-5349

this commit add validation to ssh key field

JIRA: HMS-5349
@mgold1234
Copy link
Collaborator Author

by mistake delete this pr #2764 before it was merged :(
so this is douplicate

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (0f86336) to head (80783c0).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
+ Coverage   84.75%   84.76%   +0.01%     
==========================================
  Files         187      187              
  Lines       21270    21285      +15     
  Branches     2088     2095       +7     
==========================================
+ Hits        18027    18042      +15     
  Misses       3221     3221              
  Partials       22       22              
Files with missing lines Coverage Δ
...ents/CreateImageWizard/utilities/useValidation.tsx 97.96% <100.00%> (+0.08%) ⬆️
src/Components/CreateImageWizard/validators.ts 95.00% <100.00%> (+0.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f86336...80783c0. Read the comment docs.

Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@regexowl regexowl merged commit 7d34d30 into osbuild:main Jan 23, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants