Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Services step basics (HMS-5372) #2785

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 22, 2025

This adds basic structure of the Services step.

JIRA: HMS-5372

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5371

@schutzbot schutzbot changed the title Wizard: Services step basics Wizard: Services step basics (HMS-5372) Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (c6bee55) to head (2de1b67).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
+ Coverage   84.73%   84.75%   +0.01%     
==========================================
  Files         186      187       +1     
  Lines       21248    21270      +22     
  Branches     2087     2088       +1     
==========================================
+ Hits        18005    18027      +22     
  Misses       3221     3221              
  Partials       22       22              
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 99.51% <100.00%> (+0.01%) ⬆️
...ponents/CreateImageWizard/steps/Services/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bee55...2de1b67. Read the comment docs.

This adds basic structure of the Services step.
@regexowl regexowl force-pushed the services-step-basics branch from 1f44caf to 2de1b67 Compare January 23, 2025 08:12
Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@regexowl regexowl enabled auto-merge (rebase) January 23, 2025 08:55
@regexowl regexowl merged commit 0f86336 into osbuild:main Jan 23, 2025
17 of 18 checks passed
@regexowl regexowl deleted the services-step-basics branch January 23, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants