Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: Manually bump vitest (HMS-5373) #2784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

devDeps: Manually bump vitest (HMS-5373) #2784

wants to merge 1 commit into from
+172 −266

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 22, 2025 •
edited by schutzbot
Loading

This bumps vitest and @vitest/coverage-v8 from 2.0.5 to 3.0.3.

JIRA: HMS-5373

@regexowl regexowl added the dependencies Pull requests that update a dependency file label Jan 22, 2025
@regexowl regexowl mentioned this pull request Jan 22, 2025
Closed
@regexowl
Copy link
Collaborator Author

Type needed to be added to UNIQUE_VALIDATION_DELAY so the vitest could properly mock it. It's a bit weird, but what vitest desires it shall get 🤷 (without the type the build ended in failure)

Also there is some warning mess in the test output now (Sourcemap for...). I've tried to find more info and it seems that it might be a regression. @vitejs/plugin-react most probably didn't catch up to the update yet.

And the output format changed a bit, listing all included checks, but that's just a cosmetic change.

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (6e36232) to head (080546f).

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2784   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         189      189           
  Lines       21640    21640           
  Branches     2153     2153           
=======================================
  Hits        18304    18304           
  Misses       3314     3314           
  Partials       22       22
Files with missing lines Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e36232...080546f. Read the comment docs.

@regexowl regexowl marked this pull request as ready for review January 22, 2025 08:33
@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5173

@schutzbot schutzbot changed the title devDeps: Manually bump vitest devDeps: Manually bump vitest (HMS-5373) Jan 22, 2025
@regexowl regexowl force-pushed the manual-bump-vitest branch 2 times, most recently from 52817a8 to 0211fea Compare January 27, 2025 07:48
@regexowl
devDeps: Manually bump vitest
080546f 
This bumps vitest and @vitest/coverage-v8 from 2.0.5 to 3.0.3.
mgold1234
mgold1234 reviewed Feb 3, 2025
View reviewed changes
src/constants.ts
@@ -237,7 +237,7 @@ export const EPEL_9_REPO_DEFINITION = {
};

export const DEBOUNCED_SEARCH_WAIT_TIME = 500;
export const UNIQUE_VALIDATION_DELAY = 300;
export const UNIQUE_VALIDATION_DELAY: number = 300;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it relevant to that pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgold1234 mgold1234 mgold1234 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regexowl @mgold1234