src: Fix "no-unnecessary-condition" issues (HMS-5355)

src/Components/Blueprints/BlueprintActionsMenu.tsx

@@ -63,7 +63,6 @@ export const BlueprintActionsMenu: React.FunctionComponent<
           variant="plain"
           aria-label="blueprint menu toggle"
           data-testid="blueprint-action-menu-toggle"
-          isDisabled={selectedBlueprintId === undefined}
         >
           <EllipsisVIcon aria-hidden="true" />
         </MenuToggle>

src/Components/Blueprints/BlueprintsPagination.tsx

@@ -32,7 +32,7 @@ const BlueprintsPagination = () => {
   const { data: blueprintsData } = useGetBlueprintsQuery(searchParams);
   const dispatch = useAppDispatch();
 
-  const blueprintsTotal = blueprintsData?.meta?.count || 0;
+  const blueprintsTotal = blueprintsData?.meta.count || 0;
   const onSetPage: OnSetPage = (_, page) => {
     const direction = page > currPage ? 1 : -1; // Calculate offset based on direction of paging
     const nextOffset = blueprintsOffset + direction * blueprintsLimit;

src/Components/Blueprints/BlueprintsSideBar.tsx

@@ -82,7 +82,7 @@
   const dispatch = useAppDispatch();
   const blueprints = blueprintsData?.data;
 
-  const blueprintsTotal = blueprintsData?.meta?.count || 0;
+  const blueprintsTotal = blueprintsData?.meta.count || 0;
 
   if (isLoading) {
     return (
@@ -175,7 +175,7 @@
 const BlueprintSearch = ({ blueprintsTotal }: blueprintSearchProps) => {
   const blueprintSearchInput = useAppSelector(selectBlueprintSearchInput);
   const dispatch = useAppDispatch();
   const debouncedSearch = useCallback(
     debounce((filter) => {
       dispatch(setBlueprintsOffset(0));
       dispatch(imageBuilderApi.util.invalidateTags([{ type: 'Blueprints' }]));

src/Components/Blueprints/BuildImagesButton.tsx

@@ -46,7 +46,7 @@ export const BuildImagesButton = ({ children }: BuildImagesButtonPropTypes) => {
           id: selectedBlueprintId,
           body: {
             image_types: blueprintImageType?.filter(
-              (target) => !deselectedTargets?.includes(target)
+              (target) => !deselectedTargets.includes(target)
             ),
           },
         });
@@ -78,7 +78,7 @@ export const BuildImagesButton = ({ children }: BuildImagesButtonPropTypes) => {
   ) => {
     const imageType = blueprintImageType?.[itemId];
 
-    if (imageType && deselectedTargets?.includes(imageType)) {
+    if (imageType && deselectedTargets.includes(imageType)) {
       setDeselectedTargets(
         deselectedTargets.filter((target) => target !== imageType)
       );
@@ -143,7 +143,8 @@ export const BuildImagesButton = ({ children }: BuildImagesButtonPropTypes) => {
                 hasCheckbox
                 itemId={index}
                 isSelected={
-                  !deselectedTargets || !deselectedTargets.includes(imageType)
+                  deselectedTargets.length === 0 ||
+                  !deselectedTargets.includes(imageType)
                 }
               >
                 {targetOptions[imageType]}

src/Components/Blueprints/DeleteBlueprintModal.tsx

@@ -48,7 +48,7 @@ export const DeleteBlueprintModal: React.FunctionComponent<
 
   const { blueprintName } = useGetBlueprintsQuery(searchParams, {
     selectFromResult: ({ data }) => ({
-      blueprintName: data?.data?.find(
+      blueprintName: data?.data.find(
         (blueprint: { id: string | undefined }) =>
           blueprint.id === selectedBlueprintId
       )?.name,

src/Components/Blueprints/helpers/onPremToHostedBlueprintMapper.tsx

@@ -143,7 +143,7 @@ export const mapOnPremToHosted = (
       fips:
         blueprint.customizations?.fips !== undefined
           ? {
-              enabled: blueprint.customizations?.fips,
+              enabled: blueprint.customizations.fips,
             }
           : undefined,
       timezone:

src/Components/ImagesTable/ImagesTable.tsx

@@ -103,7 +103,7 @@ const ImagesTable = () => {
     searchParamsGetBlueprints,
     {
       selectFromResult: ({ data }) => ({
-        selectedBlueprintVersion: data?.data?.find(
+        selectedBlueprintVersion: data?.data.find(
           (blueprint: BlueprintItem) => blueprint.id === selectedBlueprintId
         )?.version,
       }),

src/Components/ImagesTable/ImagesTableToolbar.tsx

@@ -76,7 +76,7 @@ const ImagesTableToolbar: React.FC<imagesTableToolbarProps> = ({
       { search: blueprintSearchInput as string },
       {
         selectFromResult: ({ data }) => {
-          const bp = data?.data?.find(
+          const bp = data?.data.find(
             (blueprint: BlueprintItem) => blueprint.id === selectedBlueprintId
           );
           return {

src/Components/ImagesTable/Instance.tsx

@@ -55,7 +55,7 @@ type CloudInstancePropTypes = {
 export const CloudInstance = ({ compose }: CloudInstancePropTypes) => {
   const { initialized: chromeInitialized } = useChrome();
   const scalprum = useScalprum();
-  const hasProvisioning = chromeInitialized && scalprum.config?.provisioning;
+  const hasProvisioning = chromeInitialized && scalprum.config.provisioning;
 
   const { data, isSuccess } = useGetComposeStatusQuery({
     composeId: compose.id,
@@ -114,7 +114,7 @@ const ProvisioningLink = ({
     { search: blueprintSearchInput },
     {
       selectFromResult: ({ data }) => ({
-        selectedBlueprintVersion: data?.data?.find(
+        selectedBlueprintVersion: data?.data.find(
           (blueprint: BlueprintItem) => blueprint.id === selectedBlueprintId
         )?.version,
       }),
@@ -128,7 +128,7 @@ const ProvisioningLink = ({
   ) {
     return <DisabledProvisioningLink />;
   } else {
-    const ProvisioningWizard = exposedScalprumModule?.default;
+    const ProvisioningWizard = exposedScalprumModule.default;
     const provider = getImageProvider(compose);
 
     const options = compose.request.image_requests[0].upload_request.options;
@@ -239,10 +239,6 @@ export const OciInstance = ({ compose, isExpired }: OciInstancePropTypes) => {
     composeId: compose.id,
   });
 
-  if (!isSuccess) {
-    return <Skeleton />;
-  }
-
   const options = data?.image_status.upload_status?.options;
 
   if (options && !isOciUploadStatus(options)) {

src/Components/ImagesTable/Status.tsx

@@ -84,7 +84,7 @@ export const AwsDetailsStatus = ({ compose }: ComposeStatusPropTypes) => {
         <ErrorStatus
           icon={statuses[data.image_status.status].icon}
           text={statuses[data.image_status.status].text}
-          error={data?.image_status?.error || ''}
+          error={data.image_status.error || ''}
         />
       );
     default:

src/Components/ImagesTable/Target.tsx

@@ -27,6 +27,6 @@ export const AwsTarget = ({ compose }: AwsTargetPropTypes) => {
     return <Skeleton />;
   }
 
-  const text = `${targetOptions.aws} (${data?.data?.length ?? 0 + 1})`;
+  const text = `${targetOptions.aws} (${data?.data.length ?? 0 + 1})`;
   return <>{text}</>;
 };

src/Components/LandingPage/LandingPage.tsx

@@ -49,7 +49,7 @@ export const LandingPage = () => {
   }, [initialActiveTabKey]);
   const handleTabClick = (_event: React.MouseEvent, tabIndex: number) => {
     const tabPath = tabsPath[tabIndex];
-    if (tabPath !== undefined) {
+    if (tabPath !== '') {
       navigate(tabPath);
     }
     setActiveTabKey(tabIndex);

src/Utilities/useDebounce.tsx

@@ -15,7 +15,7 @@ function useDebounce<T>(
     if (!isEqual(value, debouncedValue)) {
       const timer = setTimeout(
         () => setDebouncedValue(value),
-        value === '' ? 0 : delay !== undefined ? delay : 500 //If value is empty string, instantly return
+        value === '' ? 0 : delay //If value is empty string, instantly return
       );
 
       return () => {

src/test/fixtures/packages.ts

@@ -48,7 +48,7 @@ export const mockSourcesPackagesResults = (
       },
     ];
   }
-  if (search === 'mock' && isDistroPkgSearch) {
+  if (search === 'mock') {
     return [
       {
         package_name: 'mockPkg',